docs(graph): count Identity's fields as five, not four - #111
Merged
Conversation
The doc comment said "The four fields are the columns of the node table's uniqueness index ... plus the kind", which reads as four in total. The struct has five, and four is the count this change existed to correct: the old tie-break compared four keys and called two declarations equal when one file declares the same qualified name at two lines. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comment-only.
Identity's doc comment said "The four fields are the columns of the node table's uniqueness index (namespace, qualified_name, file_path, start_line) plus the kind", which reads as four in total. The struct has five.Four is the wrong number to leave next to this type: the tie-break it replaced compared four keys, and that is why it was not total — one file can declare the same qualified name at two lines, and the old comparison called those equal.
No code change.