test(search): replay raw intent matches in golden eval - #113
Merged
Conversation
Closed
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
intentrank.RankWhy
The previous golden replay froze output after intent ranking, so scorer changes could not affect
make search-eval. This restores a red-capable evaluation path for #95 while keeping production ranking behavior unchanged.Two general ranking rules were evaluated for issue 95, but both regressed other corpus metrics and were reverted. This PR therefore prepares valid measurement while leaving the ranking-debt issue open.
Validation
CGO_ENABLED=1 go test -tags "fts5" ./... -count=1CGO_ENABLED=1 go vet -tags fts5 ./...make search-evalacross ccg, cobra, context-diary, and gormccg build .ccg docs --out docsccg lintPostgreSQL parity was not rerun because no disposable PostgreSQL instance was available; the protected user-owned instance was not used.