Skip to content

test(systemctl): stabilize env-specific service tests #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
taigrr wants to merge 1 commit into from
Closed

test(systemctl): stabilize env-specific service tests #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions errors_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ import (
)

func TestErrorFuncs(t *testing.T) {
userUnit := requireUserTestUnit(t)
systemUnit := requireSystemTestUnit(t)
errFuncs := []func(ctx context.Context, unit string, opts Options) error{
func(ctx context.Context, unit string, opts Options) error { return Enable(ctx, unit, opts) },
func(ctx context.Context, unit string, opts Options) error { return Disable(ctx, unit, opts) },
Expand All @@ -29,11 +31,11 @@ func TestErrorFuncs(t *testing.T) {
// try nonexistant unit in user mode as user
{"nonexistant", ErrDoesNotExist, Options{UserMode: true}, true},
// try existing unit in user mode as user
{"syncthing", nil, Options{UserMode: true}, true},
{userUnit, nil, Options{UserMode: true}, true},
// try nonexisting unit in system mode as user
{"nonexistant", ErrInsufficientPermissions, Options{UserMode: false}, true},
// try existing unit in system mode as user
{"nginx", ErrInsufficientPermissions, Options{UserMode: false}, true},
{systemUnit, ErrInsufficientPermissions, Options{UserMode: false}, true},

/* End user tests*/

Expand All @@ -42,9 +44,9 @@ func TestErrorFuncs(t *testing.T) {
// try nonexistant unit in system mode as system
{"nonexistant", ErrDoesNotExist, Options{UserMode: false}, false},
// try existing unit in system mode as system
{"nginx", ErrBusFailure, Options{UserMode: true}, false},
{systemUnit, ErrBusFailure, Options{UserMode: true}, false},
// try existing unit in system mode as system
{"nginx", nil, Options{UserMode: false}, false},
{systemUnit, nil, Options{UserMode: false}, false},

/* End superuser tests*/

Expand Down
72 changes: 45 additions & 27 deletions helpers_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ func TestGetStartTime(t *testing.T) {
if testing.Short() {
t.Skip("skipping in short mode")
}
userUnit := requireUserTestUnit(t)
systemUnit := requireSystemTestUnit(t)
testCases := []struct {
unit string
err error
Expand All @@ -31,23 +33,23 @@ func TestGetStartTime(t *testing.T) {
// try nonexistant unit in user mode as user
{"nonexistant", ErrUnitNotActive, Options{UserMode: false}, true},
// try existing unit in user mode as user
{"syncthing", ErrUnitNotActive, Options{UserMode: true}, true},
{userUnit, ErrUnitNotActive, Options{UserMode: true}, true},
// try existing unit in system mode as user
{"nginx", nil, Options{UserMode: false}, true},
{systemUnit, nil, Options{UserMode: false}, true},

// Run these tests only as a superuser

// try nonexistant unit in system mode as system
{"nonexistant", ErrUnitNotActive, Options{UserMode: false}, false},
// try existing unit in system mode as system
{"nginx", ErrBusFailure, Options{UserMode: true}, false},
{systemUnit, ErrBusFailure, Options{UserMode: true}, false},
// try existing unit in system mode as system
{"nginx", nil, Options{UserMode: false}, false},
{systemUnit, nil, Options{UserMode: false}, false},
}
ctx, cancel := context.WithTimeout(context.Background(), 1*time.Second)
defer cancel()
Restart(ctx, "syncthing", Options{UserMode: true})
Stop(ctx, "syncthing", Options{UserMode: true})
Restart(ctx, userUnit, Options{UserMode: true})
Stop(ctx, userUnit, Options{UserMode: true})
time.Sleep(1 * time.Second)
for _, tc := range testCases {
t.Run(fmt.Sprintf("%s as %s, UserMode=%v", tc.unit, userString, tc.opts.UserMode), func(t *testing.T) {
Expand All @@ -64,6 +66,7 @@ func TestGetStartTime(t *testing.T) {
}
})
}
Start(ctx, userUnit, Options{UserMode: true})
// Prove start time changes after a restart
t.Run("prove start time changes", func(t *testing.T) {
if userString != "root" && userString != "system" {
Expand All @@ -72,17 +75,17 @@ func TestGetStartTime(t *testing.T) {

ctx, cancel := context.WithTimeout(context.Background(), 5*time.Second)
defer cancel()
startTime, err := GetStartTime(ctx, "nginx", Options{UserMode: false})
startTime, err := GetStartTime(ctx, systemUnit, Options{UserMode: false})
if err != nil {
t.Errorf("issue getting start time of nginx: %v", err)
}
time.Sleep(1 * time.Second)
err = Restart(ctx, "nginx", Options{UserMode: false})
err = Restart(ctx, systemUnit, Options{UserMode: false})
if err != nil {
t.Errorf("issue restarting nginx as %s: %v", userString, err)
}
time.Sleep(100 * time.Millisecond)
newStartTime, err := GetStartTime(ctx, "nginx", Options{UserMode: false})
newStartTime, err := GetStartTime(ctx, systemUnit, Options{UserMode: false})
if err != nil {
t.Errorf("issue getting second start time of nginx: %v", err)
}
Expand All @@ -94,6 +97,11 @@ func TestGetStartTime(t *testing.T) {
}

func TestGetNumRestarts(t *testing.T) {
userUnit := requireUserTestUnit(t)
systemUnit := requireSystemTestUnit(t)
ctx, cancel := context.WithTimeout(context.Background(), 5*time.Second)
defer cancel()
Start(ctx, userUnit, Options{UserMode: true})
type testCase struct {
unit string
err error
Expand All @@ -106,18 +114,18 @@ func TestGetNumRestarts(t *testing.T) {
// try nonexistant unit in user mode as user
{"nonexistant", ErrValueNotSet, Options{UserMode: false}, true},
// try existing unit in user mode as user (loaded, so NRestarts=0 is valid)
{"syncthing", nil, Options{UserMode: true}, true},
{userUnit, nil, Options{UserMode: true}, true},
// try existing unit in system mode as user
{"nginx", nil, Options{UserMode: false}, true},
{systemUnit, nil, Options{UserMode: false}, true},

// Run these tests only as a superuser

// try nonexistant unit in system mode as system
{"nonexistant", ErrValueNotSet, Options{UserMode: false}, false},
// try existing unit in system mode as system
{"nginx", ErrBusFailure, Options{UserMode: true}, false},
{systemUnit, ErrBusFailure, Options{UserMode: true}, false},
// try existing unit in system mode as system
{"nginx", nil, Options{UserMode: false}, false},
{systemUnit, nil, Options{UserMode: false}, false},
}
for _, tc := range testCases {
func(tc testCase) {
Expand Down Expand Up @@ -148,25 +156,25 @@ func TestGetNumRestarts(t *testing.T) {

ctx, cancel := context.WithTimeout(context.Background(), 5*time.Second)
defer cancel()
restarts, err := GetNumRestarts(ctx, "nginx", Options{UserMode: false})
restarts, err := GetNumRestarts(ctx, systemUnit, Options{UserMode: false})
if err != nil {
t.Errorf("issue getting number of restarts for nginx: %v", err)
}
pid, err := GetPID(ctx, "nginx", Options{UserMode: false})
pid, err := GetPID(ctx, systemUnit, Options{UserMode: false})
if err != nil {
t.Errorf("issue getting MainPID for nginx as %s: %v", userString, err)
}
syscall.Kill(pid, syscall.SIGKILL)
for {
running, errIsActive := IsActive(ctx, "nginx", Options{UserMode: false})
running, errIsActive := IsActive(ctx, systemUnit, Options{UserMode: false})
if errIsActive != nil {
t.Errorf("error asserting nginx is up: %v", errIsActive)
break
} else if running {
break
}
}
secondRestarts, err := GetNumRestarts(ctx, "nginx", Options{UserMode: false})
secondRestarts, err := GetNumRestarts(ctx, systemUnit, Options{UserMode: false})
if err != nil {
t.Errorf("issue getting second reading on number of restarts for nginx: %v", err)
}
Expand All @@ -177,6 +185,11 @@ func TestGetNumRestarts(t *testing.T) {
}

func TestGetMemoryUsage(t *testing.T) {
userUnit := requireUserTestUnit(t)
systemUnit := requireSystemTestUnit(t)
ctx, cancel := context.WithTimeout(context.Background(), 5*time.Second)
defer cancel()
Start(ctx, userUnit, Options{UserMode: true})
type testCase struct {
unit string
err error
Expand All @@ -189,18 +202,18 @@ func TestGetMemoryUsage(t *testing.T) {
// try nonexistant unit in user mode as user
{"nonexistant", ErrValueNotSet, Options{UserMode: false}, true},
// try existing unit in user mode as user
{"syncthing", ErrValueNotSet, Options{UserMode: true}, true},
{userUnit, nil, Options{UserMode: true}, true},
// try existing unit in system mode as user
{"nginx", nil, Options{UserMode: false}, true},
{systemUnit, nil, Options{UserMode: false}, true},

// Run these tests only as a superuser

// try nonexistant unit in system mode as system
{"nonexistant", ErrValueNotSet, Options{UserMode: false}, false},
// try existing unit in system mode as system
{"nginx", ErrBusFailure, Options{UserMode: true}, false},
{systemUnit, ErrBusFailure, Options{UserMode: true}, false},
// try existing unit in system mode as system
{"nginx", nil, Options{UserMode: false}, false},
{systemUnit, nil, Options{UserMode: false}, false},
}
for _, tc := range testCases {
func(tc testCase) {
Expand All @@ -224,7 +237,7 @@ func TestGetMemoryUsage(t *testing.T) {
t.Run("prove memory usage values change across services", func(t *testing.T) {
ctx, cancel := context.WithTimeout(context.Background(), 1*time.Second)
defer cancel()
bytes, err := GetMemoryUsage(ctx, "nginx", Options{UserMode: false})
bytes, err := GetMemoryUsage(ctx, systemUnit, Options{UserMode: false})
if err != nil {
t.Errorf("issue getting memory usage of nginx: %v", err)
}
Expand Down Expand Up @@ -287,6 +300,11 @@ func TestGetUnits(t *testing.T) {
}

func TestGetPID(t *testing.T) {
userUnit := requireUserTestUnit(t)
systemUnit := requireSystemTestUnit(t)
ctx, cancel := context.WithTimeout(context.Background(), 5*time.Second)
defer cancel()
Start(ctx, userUnit, Options{UserMode: true})
type testCase struct {
unit string
err error
Expand All @@ -300,18 +318,18 @@ func TestGetPID(t *testing.T) {
// try nonexistant unit in user mode as user
{"nonexistant", nil, Options{UserMode: false}, true},
// try existing unit in user mode as user
{"syncthing", nil, Options{UserMode: true}, true},
{userUnit, nil, Options{UserMode: true}, true},
// try existing unit in system mode as user
{"nginx", nil, Options{UserMode: false}, true},
{systemUnit, nil, Options{UserMode: false}, true},

// Run these tests only as a superuser

// try nonexistant unit in system mode as system
{"nonexistant", nil, Options{UserMode: false}, false},
// try existing unit in system mode as system
{"nginx", ErrBusFailure, Options{UserMode: true}, false},
{systemUnit, ErrBusFailure, Options{UserMode: true}, false},
// try existing unit in system mode as system
{"nginx", nil, Options{UserMode: false}, false},
{systemUnit, nil, Options{UserMode: false}, false},
}
for _, tc := range testCases {
func(tc testCase) {
Expand All @@ -338,7 +356,7 @@ func TestGetPID(t *testing.T) {
if userString != "root" && userString != "system" {
t.Skip("skipping superuser test while running as user")
}
unit := "nginx"
unit := systemUnit
ctx, cancel := context.WithTimeout(context.Background(), 1*time.Second)
defer cancel()
Restart(ctx, unit, Options{UserMode: true})
Expand Down
2 changes: 1 addition & 1 deletion systemctl_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,7 +461,7 @@ func TestStart(t *testing.T) {
}

func TestStatus(t *testing.T) {
unit := "nginx"
unit := requireSystemTestUnit(t)
userMode := false
opts := Options{UserMode: userMode}
ctx, cancel := context.WithTimeout(context.Background(), 10*time.Second)
Expand Down
Loading
Loading