-
Notifications
You must be signed in to change notification settings - Fork 0
π₯ Contain document filesystem access behind API.Files (#227) #403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
c5e5b08
81a26c4
36b662b
8e21506
1c0faba
99162d8
f869b68
ab552cc
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
|
|
@@ -8,7 +8,7 @@ | |||||||
| import { main } from "effection"; | ||||||||
| import { fileURLToPath } from "node:url"; | ||||||||
| import process from "node:process"; | ||||||||
| import { API } from "@executablemd/runtime"; | ||||||||
| import { API, useHostFiles } from "@executablemd/runtime"; | ||||||||
| import { compileDataUri } from "@executablemd/core"; | ||||||||
| import { runXmd } from "./cli.ts"; | ||||||||
| import { useBunService } from "./bun-service.ts"; | ||||||||
|
|
@@ -30,5 +30,10 @@ await main(function* (args) { | |||||||
| }, | ||||||||
| { at: "min" }, | ||||||||
| ); | ||||||||
| // Document filesystem access resolves in the caller's own filesystem here. | ||||||||
| // It is installed explicitly, and at the same depth, because `API.Files` has | ||||||||
| // no host default: a run with no provider must fail rather than reach the | ||||||||
| // host by accident. | ||||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Redundant comment β restates what the code does.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Redundant comment β restates what the code does.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Redundant comment β restates what the code does.
Suggested change
|
||||||||
| yield* useHostFiles(); | ||||||||
| yield* runXmd(args, useBunService); | ||||||||
| }); | ||||||||
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -7,7 +7,7 @@ | |||||||||
|
|
||||||||||
| import { main } from "effection"; | ||||||||||
| import process from "node:process"; | ||||||||||
| import { API } from "@executablemd/runtime"; | ||||||||||
| import { API, useHostFiles } from "@executablemd/runtime"; | ||||||||||
| import { compileDataUri } from "@executablemd/core"; | ||||||||||
| import { runXmd } from "./cli.ts"; | ||||||||||
| import { useCompiledService } from "./compiled-service.ts"; | ||||||||||
|
|
@@ -27,5 +27,10 @@ await main(function* (args) { | |||||||||
| }, | ||||||||||
| { at: "min" }, | ||||||||||
| ); | ||||||||||
| // Document filesystem access resolves in the caller's own filesystem here. | ||||||||||
| // It is installed explicitly, and at the same depth, because `API.Files` has | ||||||||||
| // no host default: a run with no provider must fail rather than reach the | ||||||||||
| // host by accident. | ||||||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Redundant comment β restates what the code does.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Redundant comment β restates what the code does.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Redundant comment β restates what the code does.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Redundant comment β restates what the code does.
Suggested change
|
||||||||||
| yield* useHostFiles(); | ||||||||||
| yield* runXmd(args, useCompiledService); | ||||||||||
| }); | ||||||||||
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -10,7 +10,7 @@ | |||||||||
| import { main } from "effection"; | ||||||||||
| import { fileURLToPath } from "node:url"; | ||||||||||
| import process from "node:process"; | ||||||||||
| import { API } from "@executablemd/runtime"; | ||||||||||
| import { API, useHostFiles } from "@executablemd/runtime"; | ||||||||||
| import { compileDataUri } from "@executablemd/core"; | ||||||||||
| import { runXmd } from "./cli.ts"; | ||||||||||
| import { useDenoService } from "./deno-service.ts"; | ||||||||||
|
|
@@ -32,5 +32,10 @@ await main(function* (args) { | |||||||||
| }, | ||||||||||
| { at: "min" }, | ||||||||||
| ); | ||||||||||
| // Document filesystem access resolves in the caller's own filesystem here. | ||||||||||
| // It is installed explicitly, and at the same depth, because `API.Files` has | ||||||||||
| // no host default: a run with no provider must fail rather than reach the | ||||||||||
| // host by accident. | ||||||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Redundant comment β restates what the code does.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Redundant comment β restates what the code does.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Redundant comment β restates what the code does.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Redundant comment β restates what the code does.
Suggested change
|
||||||||||
| yield* useHostFiles(); | ||||||||||
| yield* runXmd(args, useDenoService); | ||||||||||
| }); | ||||||||||
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -14,7 +14,7 @@ | |||||||||
| import { main } from "effection"; | ||||||||||
| import { fileURLToPath } from "node:url"; | ||||||||||
| import process from "node:process"; | ||||||||||
| import { API } from "@executablemd/runtime"; | ||||||||||
| import { API, useHostFiles } from "@executablemd/runtime"; | ||||||||||
| import { compileTempFile } from "@executablemd/core"; | ||||||||||
| import { runXmd } from "./cli.ts"; | ||||||||||
| import { useNodeService } from "./node-service.ts"; | ||||||||||
|
|
@@ -37,5 +37,10 @@ await main(function* (args) { | |||||||||
| }, | ||||||||||
| { at: "min" }, | ||||||||||
| ); | ||||||||||
| // Document filesystem access resolves in the caller's own filesystem here. | ||||||||||
| // It is installed explicitly, and at the same depth, because `API.Files` has | ||||||||||
| // no host default: a run with no provider must fail rather than reach the | ||||||||||
| // host by accident. | ||||||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Redundant comment β restates what the code does.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Redundant comment β restates what the code does.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Redundant comment β restates what the code does.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Redundant comment β restates what the code does.
Suggested change
|
||||||||||
| yield* useHostFiles(); | ||||||||||
| yield* runXmd(args, useNodeService); | ||||||||||
| }); | ||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Redundant comment β restates what the code does.