Skip to content
This repository was archived by the owner on Jun 11, 2020. It is now read-only.

Use WebView from react-native-webview as it has been deprecated from …#20

Open
cj3g10 wants to merge 2 commits into
teamairship:masterfrom
cj3g10:master
Open

Use WebView from react-native-webview as it has been deprecated from …#20
cj3g10 wants to merge 2 commits into
teamairship:masterfrom
cj3g10:master

Conversation

@cj3g10
Copy link
Copy Markdown

@cj3g10 cj3g10 commented Feb 26, 2019

Use WebView from react-native-webview as it has been deprecated from react-native and will be removed in future release.

See https://facebook.github.io/react-native/docs/webview for more info.

@amhinson
Copy link
Copy Markdown
Collaborator

awesome! Thanks for the PR. I'll check it out later today and merge it.

@amhinson
Copy link
Copy Markdown
Collaborator

A couple of things:

  • I think we will also need to add react-native link react-native-webview to the install instructions.
  • It looks like the import in iosWebView.js should be import { WebView } from "react-native-webview";

@amhinson
Copy link
Copy Markdown
Collaborator

Also, it looks like there is a PR in react-native-webview to add this functionality. If it works in a similar way, I will likely deprecate this library in favor of that:
react-native-webview/react-native-webview#325

@mikaoelitiana
Copy link
Copy Markdown

Some more changes seems to be required for android, I made another PR #28

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants