Skip to content

Make AWS Lambda role and external ID optional in create-version - #1140

Open
mani-j9 wants to merge 2 commits into
mainfrom
mani/relax-lambda-role-eid-validation
Open

Make AWS Lambda role and external ID optional in create-version#1140
mani-j9 wants to merge 2 commits into
mainfrom
mani/relax-lambda-role-eid-validation

Conversation

@mani-j9

@mani-j9 mani-j9 commented Jul 28, 2026

Copy link
Copy Markdown

create-version and update-version-compute-config hard-required --aws-lambda-assume-role-arn and --aws-lambda-assume-role-external-id whenever --aws-lambda-function-arn was set. The server already governs this via the global require_role_and_external_id setting (default true), so the client check duplicated server policy and blocked valid role-less configs — e.g. local dev against LocalStack with the setting disabled.

The updated create-version error tests assert the server-side rejection.

🤖 Generated with Claude Code

The server enforces them via the require_role_and_external_id setting, so the CLI requires only the function ARN and defers that policy to the server.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@mani-j9
mani-j9 requested a review from a team as a code owner July 28, 2026 17:29
@CLAassistant

CLAassistant commented Jul 28, 2026

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ mani-j9
❌ mani


mani seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


mani seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants