Fix inverted --yes description on operator namespace delete - #1143
Open
starfleeth wants to merge 1 commit into
Open
Fix inverted --yes description on operator namespace delete#1143starfleeth wants to merge 1 commit into
--yes description on operator namespace delete#1143starfleeth wants to merge 1 commit into
Conversation
The flag was documented as "Request confirmation before deletion." when it does the opposite: it supplies the confirmation so the delete proceeds unattended. New wording matches the other 16 --yes flags in commands.yaml. Closes #1142 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
|
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
Closes #1142
What changed?
temporal operator namespace deletedocumented-y, --yesas "Request confirmation before deletion." It does the opposite — it supplies the confirmation so the delete runs unattended. The behavior is correct and unchanged; only the description was wrong.New wording matches the other 16
--yesflags incommands.yaml, all of which use "Don't prompt to confirm …". This was the only one that deviated. Repro and detail in #1142.No test added: the description is display-only metadata with no execution path, which is also why this survived — it can't fail a test, a build, or a review of the Go.
commands.gen.gowas hand-applied, not regenerated (no Go toolchain on this machine). The string appears exactly once as a plain literal, so it should be byte-identical to generator output — theRegen code, confirm unchangedCI step will confirm.