Add version to build#81
Merged
Merged
Conversation
jeri-temporal
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Build and documentation changes only; no runtime logic or security-sensitive code paths modified.
Overview
make buildnow stamps thetemporal-cloudbinary with a release version by passing-ldflagsthat settemporalcloudcli.Versionfromgit describe --tags --always --dirty. If git is unavailable, the ldflag is omitted so the existing in-code default (0.0.0-DEV) stays unchanged.The README build section now points readers to
make buildonly, instead of also mentioning a rawgo build.Reviewed by Cursor Bugbot for commit f060bb1. Bugbot is set up for automated code reviews on this repo. Configure here.