fix(observability): fixed code snippets in TypeScript observability#4882
Open
flippedcoder wants to merge 3 commits into
Open
fix(observability): fixed code snippets in TypeScript observability#4882flippedcoder wants to merge 3 commits into
flippedcoder wants to merge 3 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| } | ||
| ``` | ||
|
|
||
| ## Workflow Sinks |
Contributor
There was a problem hiding this comment.
📝 [vale] reported by reviewdog 🐶
[Temporal.Headings] 'Workflow Sinks' should use sentence-style capitalization.
| Sinks are written as objects with methods. | ||
| Similar to Activities, they are declared in the Worker and then proxied in Workflow code, and it helps to share types between both. | ||
|
|
||
| ### Comparing Sinks and Activities |
Contributor
There was a problem hiding this comment.
📝 [vale] reported by reviewdog 🐶
[Temporal.Headings] 'Comparing Sinks and Activities' should use sentence-style capitalization.
Contributor
📖 Docs PR preview links
|
Duncanma
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
DefaultLoggerinstances.Notes to reviewers
┆Attachments: EDU-6715 fix(observability): fixed code snippets in TypeScript observability