AI-304: Layout-agnostic shared eslintrc; fix outdated post-create messages#483
Open
xumaple wants to merge 1 commit into
Open
AI-304: Layout-agnostic shared eslintrc; fix outdated post-create messages#483xumaple wants to merge 1 commit into
xumaple wants to merge 1 commit into
Conversation
…d post-create messages Broaden the shared eslintrc workflow-override glob to src/**/workflows*.ts so the no-node-builtins rule covers nested per-scenario layouts (e.g. openai-agents' src/<feature>/workflows.ts). This lets openai-agents use the shared eslintrc and drop out of ESLINTRC_EXCLUDE; all samples' eslintrc copies are re-synced. Fix 8 samples whose .post-create told users to run npm scripts that don't exist (start.watch/workflow): each now has a tailored message matching its real scripts, and is excluded from the shared post-create.
brianstrauch
approved these changes
Jun 24, 2026
brianstrauch
left a comment
brianstrauch
left a comment
Member
There was a problem hiding this comment.
Interesting that this was a widespread issue. Thanks for fixing!
chris-olszewski
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Broaden the shared eslintrc workflow-override glob to
src/**/workflows*.tsso the no-node-builtins rule covers nested per-scenario layouts (e.g. openai-agents'src/<feature>/workflows.ts), letting openai-agents use the shared eslintrc and drop out ofESLINTRC_EXCLUDE. All samples' eslintrc copies are re-synced.Also fixes 8 samples (env-config, dsl-interpreter, eager-workflow-start, standalone-activity, state, nexus-cancellation, nexus-hello, nexus-messaging) whose
.post-createtold users to run npm scripts that don't exist (start.watch/workflow); each now matches its real scripts and is excluded from the shared post-create.