Skip to content

Fix pre-push hook crash from orphaned ci.yml updater #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xumaple merged 1 commit into from
Jun 25, 2026
Merged

Fix pre-push hook crash from orphaned ci.yml updater #484

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 0 additions & 33 deletions .scripts/copy-shared-files.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
// Run with https://github.com/google/zx
const { readFileSync } = require('fs');

const STORED_SAMPLES = new Set(require('./list-of-samples.json').samples);

const yaml = require('yaml');

const NON_SAMPLES = ['node_modules'];
const ADDITIONAL_SAMPLES = [];

Expand Down Expand Up @@ -201,35 +197,6 @@ for (const sample of samples) {
await copyAndAdd(sample, '.nvmrc');
}

process.stdout.write('Updating GitHub workflows...');

const ciConfig = yaml.parseDocument(await fs.readFile('.github/workflows/ci.yml', 'utf8'));
const jobsNode = ciConfig.contents.items.find((i) => i.key.value === 'jobs');
const testNode = jobsNode.value.items.find((i) => i.key.value === 'test-individual');
const testProjectsNode = testNode.value.items
.find((i) => i.key.value === 'strategy')
.value.items.find((i) => i.key.value === 'matrix')
.value.items.find((i) => i.key.value === 'project');

testProjectsNode.value.items = [];

for (const sample of samples) {
// Don't use require, because it won't work with ESM samples
const packageJson = JSON.parse(readFileSync(`./${sample}/package.json`));
const hasTestScript = !!packageJson.scripts.test;

if (hasTestScript) {
testProjectsNode.value.items.push(sample);
} else {
const index = testProjectsNode.value.items.indexOf(sample);
if (index >= 0) {
testProjectsNode.value.items.splice(index, 1);
}
}
}

await fs.writeFile('.github/workflows/ci.yml', ciConfig.toString());

console.log(' done.');

async function copyAndAdd(sample, file) {
Expand Down
Loading