Standalone Activities start delay#2906
Open
GregoryTravis wants to merge 6 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
setStartDelay(Duration)toStartActivityOptionsfor Standalone Activities.Mirrors the existing
WorkflowOptions.setStartDelay(...)semantics on the activity side. When set, the server creates the activity immediately (visible in describe/list responses with statusRUNNING, run stateSCHEDULED) but defers dispatch to a worker until the delay elapses.Spec
Public API surface
setStartDelay(Duration)toStartActivityOptions.BuilderIllegalArgumentExceptionif negativeDifferences from the cross-SDK siblings
Behavior covered by tests
StartActivityOptionsTest::testNegativeStartDelayFails(unit)IllegalArgumentExceptionraised at setter time for negative valuesStartActivityOptionsTest::testZeroStartDelayAccepted(unit)Duration.ZEROaccepted as a valid valueStartActivityOptionsTest::testToBuilderPreservesAllFields(unit, extended)startDelaysurvivestoBuilder()round-tripStandaloneActivityTest::testStartDelayDelaysFirstDispatchlastStartedTime − scheduledTime >= startDelay − 500msStandaloneActivityTest::testZeroStartDelayBehavesAsUnsetDuration.ZEROproduces near-immediate dispatchStandaloneActivityTest::testCancelDuringStartDelaycancel()cancels immediatelyStandaloneActivityTest::testTerminateDuringStartDelayterminate()cancels immediatelyStandaloneActivityTest::testStartDelayPreservesScheduleToStartTimeoutscheduleToStartTimeout = 1s+startDelay = 2sdispatches successfullyStandaloneActivityTest::testStartDelayPreservesScheduleToCloseTimeoutscheduleToCloseTimeout = 1s+startDelay = 2sfor SchedToCloseStandaloneActivityTest::testStartDelayNotReappliedOnRetryTest environment
.github/workflows/ci.yml:TEMPORAL_CLI_VERSIONfrom1.7.0to1.7.1-standalone-nexus-operations. CLI v1.7.0 bundles serverv1.31.0, which does not include the start-delay implementation--dynamic-config-value activity.startDelayEnabled=trueto the dev-server args.