Fix flaky test NexusWorkflowTest.testNexusOperationTimeout_AfterStart#2908
Merged
maciejdudko merged 1 commit intoJun 10, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
NexusWorkflowTest.testNexusOperationTimeout_AfterStartto handle Nexus operation timeout before operation start and to use larger timeout.v1.7.1-standalone-nexus-operationsWhy?
Server has introduced small regression in handling of very short schedule-to-close timeouts for Nexus operations, which exposed a bug in this test - it only handled the case where the operation starts successfully and only times out later. It didn't handle the case where the timeout happened before the operation starts, but we have no way to control whether timeout happens before or after start.
The new CLI version is needed by several pending PRs, and contains the regression. The version was bumped here so we can validate the fixed test against the new server version.