Add OpenTracing interceptor for standalone activities#2909
Open
444am wants to merge 2 commits into
Open
Conversation
|
|
|
|
444am
force-pushed
the
444am/activity-client-otel-interceptor
branch
from
e6a59c7 to
ee62c8f
Compare
444am
commented
Jun 11, 2026
| SpanCreationContext context = | ||
| SpanCreationContext.newBuilder() | ||
| .setSpanOperationType(operationType) | ||
| .setActionName("StandaloneActivity") |
Author
There was a problem hiding this comment.
ActionName has to be set for getSpanName(), but ActivityType is not provided in GetActivityResultInput / DescribeActivityInput etc. To minimize the cardinality I'm using a fixed placeholder here as of now. Let me know if you believe repeatedly using activityId for distinction would be better.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Added OpenTracing support for standalone activity client operations.
Why?
Standalone activities can be started and managed through ActivityClient, but the OpenTracing contrib module did not trace those client operations. This adds tracing
coverage consistent with the existing workflow client and worker tracing patterns.
Standalone activity execution also needs its own worker-side run span because standalone activities do not have workflow IDs or workflow run IDs.
How was this tested:
See 2 UT files for Client and Worker respectively.