Add __getattr__ to _ReplaySafeSpan for SDK attribute delegation#1392
Merged
tconley1428 merged 1 commit intomainfrom Mar 25, 2026
Merged
Add __getattr__ to _ReplaySafeSpan for SDK attribute delegation#1392tconley1428 merged 1 commit intomainfrom
tconley1428 merged 1 commit intomainfrom
Conversation
Instrumentation libraries like opentelemetry-instrumentation-asgi access attributes beyond the Span ABC (e.g. .name, .kind, .resource, .attributes) directly on spans. _ReplaySafeSpan now forwards these via __getattr__ to the wrapped span. Also removes dead self._status assignment in set_status. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
THardy98
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
__getattr__to_ReplaySafeSpanso that SDK-specific span attributes (.name,.kind,.resource,.attributes, etc.) are delegated to the underlying span. Instrumentation libraries likeopentelemetry-instrumentation-asgiaccess these directly.self._statusassignment inset_status(was written but never read).AttributeErrorfor missing ones.Test plan
test_replay_safe_span_delegates_extra_attributestest passes__getattr__change🤖 Generated with Claude Code