Skip to content

Expose gRPC compression options#470

Open
Sushisource wants to merge 1 commit into
mainfrom
core-compression-options
Open

Expose gRPC compression options#470
Sushisource wants to merge 1 commit into
mainfrom
core-compression-options

Conversation

@Sushisource

@Sushisource Sushisource commented Jun 26, 2026

Copy link
Copy Markdown
Member

Summary

  • expose gRPC compression as concrete option variants on client connection options
  • keep gzip as the default while allowing Temporalio::Client::Connection::GrpcCompressionOptions::None.new to opt out
  • model the public/RBS types so future variants can add variant-specific fields, e.g. a zstd class with a level, without adding level to gzip

Testing

  • bundle exec rubocop
  • ruby -c temporalio/lib/temporalio/client.rb
  • ruby -c temporalio/lib/temporalio/client/connection.rb
  • ruby -c temporalio/test/client_test.rb

@Sushisource Sushisource force-pushed the core-compression-options branch 3 times, most recently from 21e0cc4 to c4e1c94 Compare June 26, 2026 22:30
@Sushisource Sushisource marked this pull request as ready for review June 26, 2026 22:35
@Sushisource Sushisource requested a review from a team as a code owner June 26, 2026 22:35
@Sushisource Sushisource force-pushed the core-compression-options branch from c4e1c94 to 4dbf7a5 Compare June 26, 2026 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant