docs(t5): recommend PNG/WebP for logoURI per TIP-1026, not SVG#452
Merged
Conversation
The 'use an SVG for logoURI' note I added in #405 contradicts the actual TIP-1026 spec, which says: Rasterized formats (PNG / WebP / static, single-frame) are recommended over SVG; integrators that accept SVG must follow the SVG-handling guidance in Security Considerations. Flagged by malleshpai on #450 for the TIP-20 spec appendix (fixed in that PR). This PR fixes the same incorrect note on the remaining three pages it shipped to: - protocol/upgrades/t5.mdx (TIP-1026 integration changes section) - guide/issuance/create-a-stablecoin.mdx (Coming with T5 callout) - guide/issuance/manage-stablecoin.mdx (Coming with T5 callout) Each now points at TIP-1026's 'Recommended Formats' section and notes that SVG is allowed by the scheme allowlist but not recommended, mirroring TIP-1026 verbatim. The quickstart/tokenlist.mdx Icon Requirements section is a separate off-chain API contract (the tokenlist serves vector icons via its own /icon endpoint) and is intentionally not changed here. Amp-Thread-ID: https://ampcode.com/threads/T-019e6e22-0805-7628-b3b5-899366ecd1f6 Co-authored-by: Amp <amp@ampcode.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
jenpaff
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the
logoURIformat recommendation on the 3 pages that still say "use an SVG" — TIP-1026 actually recommends PNG / WebP:Pages updated:
protocol/upgrades/t5.mdx— TIP-1026 integration changes sectionguide/issuance/create-a-stablecoin.mdx— Coming-with-T5 calloutguide/issuance/manage-stablecoin.mdx— Coming-with-T5 calloutThe TIP-20 spec appendix was already fixed in #450 per @malleshpai's review.
quickstart/tokenlist.mdxIcon Requirements is the off-chain tokenlist API contract and is intentionally not changed.Amp-Thread-ID: https://ampcode.com/threads/T-019e6e22-0805-7628-b3b5-899366ecd1f6