Skip to content

fix(neo4j) Swap out use of depricated wait utils for wait_strategies #1012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
icfly2 wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −4
Open

fix(neo4j) Swap out use of depricated wait utils for wait_strategies #1012

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions modules/neo4j/testcontainers/neo4j/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,7 @@
from testcontainers.core.config import testcontainers_config as c
from testcontainers.core.generic import DbContainer
from testcontainers.core.utils import raise_for_deprecated_parameter
from testcontainers.core.waiting_utils import wait_container_is_ready, wait_for_logs

from testcontainers.core.wait_strategies import LogMessageWaitStrategy

class Neo4jContainer(DbContainer):
"""
Expand Down Expand Up @@ -60,9 +59,10 @@ def _configure(self) -> None:
def get_connection_url(self) -> str:
return f"bolt://{self.get_container_host_ip()}:{self.get_exposed_port(self.port)}"

@wait_container_is_ready()
def _connect(self) -> None:
wait_for_logs(self, "Remote interface available at", c.timeout)
wait_strategy = LogMessageWaitStrategy("Remote interface available at")
wait_strategy.with_startup_timeout(c.timeout)
wait_strategy.wait_until_ready(self)

# Then we actually check that the container really is listening
with self.get_driver() as driver:
Expand Down