feat(keycloak): support for relative path and management relative path#982
Open
JotBePunkt wants to merge 2 commits intotestcontainers:mainfrom
Open
feat(keycloak): support for relative path and management relative path#982JotBePunkt wants to merge 2 commits intotestcontainers:mainfrom
JotBePunkt wants to merge 2 commits intotestcontainers:mainfrom
Conversation
When these parameters were set, the functions get_url() and get_management_url() did return the wrong URLs (without the prefix) Now the implementation checks if the parameter is checked and adds it to the returned URL
Author
|
@alexanderankin it would be great, if this change is in one of the next releases. What do we need to do to have this PR merged? |
Member
|
i started rebasing a bigger PR yesterday, working through merging all the things |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When these parameters were set, the functions get_url() and get_management_url() did return the wrong URLs (without the prefix)
Now the implementation checks if the parameter is checked and adds it to the returned URL
This solves #964