Skip to content

CI: Build Detours library before RemoteNET solution#67

Merged
theXappy merged 3 commits intomainfrom
copilot/update-github-actions-workflow
Apr 11, 2026
Merged

CI: Build Detours library before RemoteNET solution#67
theXappy merged 3 commits intomainfrom
copilot/update-github-actions-workflow

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 11, 2026

  • Explore repo and existing workflow
  • Add msbuild /t:restore,build ALL_BUILD.vcxproj to the "Prepare Detours library" step
  • Map matrix Release -> RelWithDebInfo and Debug -> Debug for Detours /p:Configuration
  • Validate workflow YAML is correct
Original prompt

Repository: theXappy/RemoteNET

Goal
Add a GitHub Actions workflow step to compile Detours, matching the README build instructions:

  • Run cmake ..\detours.net
  • Run msbuild /t:restore,build ALL_BUILD.vcxproj

Context
Workflow file to modify:

  • .github/workflows/dotnet-desktop.yml (on branch main)

Requirements

  1. Update the workflow so Detours is built before building the RemoteNET solution/projects.
  2. Ensure the commands run on the appropriate Windows runner and from the correct working directory so the relative path ..\detours.net works (or adjust paths appropriately while keeping the same build intent).
  3. Prefer using the MSBuild that comes with the Visual Studio Build Tools installed on the runner (use microsoft/setup-msbuild or vswhere as needed).
  4. Keep the workflow readable and consistent with existing style.
  5. If the workflow already uses CMake/MSBuild, integrate without duplicating setup.

Deliverable
A pull request to theXappy/RemoteNET updating .github/workflows/dotnet-desktop.yml to compile Detours in CI.

Reference instructions (from README)

cmake ..\detours.net
msbuild /t:restore,build ALL_BUILD.vcxproj
Open RemoteNET.sln in Visual Studio
Compile the RemoteNET project

The following is the prior conversation context from the user's chat exploration (may be truncated):

User: Add a step to compile Detours
just like I have in the readme

cmake ..\detours.net
msbuild /t:restore,build ALL_BUILD.vcxproj
Open RemoteNET.sln in Visual Studio
Compile the RemoteNET project

Assistant: I’ve queued up the change to add the Detours build step to the workflow, and I’m waiting for your approval in the prompt/dialog so I can proceed.

This pull request was created from Copilot chat.

@theXappy theXappy marked this pull request as ready for review April 11, 2026 15:19
Copilot AI changed the title [WIP] Add workflow step to compile Detours in GitHub Actions CI: Build Detours library before RemoteNET solution Apr 11, 2026
Copilot AI requested a review from theXappy April 11, 2026 15:20
@theXappy
Copy link
Copy Markdown
Owner

@copilot we're missing /p:Configuration=RelWithDebInfo when the type of build is "Release". fix it in a way that dues this or "Debug" depending on the yaml parameter

Copy link
Copy Markdown
Contributor Author

Copilot AI commented Apr 11, 2026

@copilot we're missing /p:Configuration=RelWithDebInfo when the type of build is "Release". fix it in a way that dues this or "Debug" depending on the yaml parameter

Done in commit 4ef1022. Added a Detours_Configuration env var that maps the matrix value: ReleaseRelWithDebInfo, DebugDebug using a GitHub Actions inline conditional expression:

env:
  Detours_Configuration: ${{ matrix.configuration == 'Release' && 'RelWithDebInfo' || matrix.configuration }}

This is then passed to msbuild as /p:Configuration=$env:Detours_Configuration.

@theXappy theXappy merged commit 511892f into main Apr 11, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants