Skip to content

feat(storage): enable CRC32C validation by default in transfer manager #17

Open
thiyaguk09 wants to merge 4 commits into
mainfrom
feat/full-object-checksum-reads
Open

feat(storage): enable CRC32C validation by default in transfer manager #17
thiyaguk09 wants to merge 4 commits into
mainfrom
feat/full-object-checksum-reads

Conversation

@thiyaguk09
Copy link
Copy Markdown
Owner

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@thiyaguk09 thiyaguk09 changed the title feat: enable CRC32C validation by default in transfer manager feat(storage): enable CRC32C validation by default in transfer manager May 22, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the downloadFileInChunks method in TransferManager to enable CRC32C validation by default and ensures that validation is performed only on the final assembled file rather than on individual chunks. The review feedback suggests refining the logic for defaulting the validation method to ensure that explicitly provided validation strings are respected instead of being coerced to 'crc32c'.

Comment thread handwritten/storage/src/transfer-manager.ts Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants