feat(storage): enable CRC32C validation by default in transfer manager #17
Open
thiyaguk09 wants to merge 4 commits into
Open
feat(storage): enable CRC32C validation by default in transfer manager #17thiyaguk09 wants to merge 4 commits into
thiyaguk09 wants to merge 4 commits into
Conversation
…able it for individual shard downloads
There was a problem hiding this comment.
Code Review
This pull request updates the downloadFileInChunks method in TransferManager to enable CRC32C validation by default and ensures that validation is performed only on the final assembled file rather than on individual chunks. The review feedback suggests refining the logic for defaulting the validation method to ensure that explicitly provided validation strings are respected instead of being coerced to 'crc32c'.
…default handling logic
…ng input to crc32c
gurusai-voleti
approved these changes
May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕