Add post-run cleanup for integration tests - #168
Conversation
Fixed error at the end of the camera test where the x and y position would not be reset if moved. This was causing the problem of other tests not having the camera centered
rory-cd
left a comment
There was a problem hiding this comment.
General Information
Type of Change:
- Bug fix
Nice and simple solution. I've tested in WSL via sktest and it completely resolves the issue. Good pickup on the bundle problem. I believe this has been addressed in another PR (two actually, I think it was a duplicate ticket).
Code Quality
- Repository: Thoth-Tech NOT SplashKit
- Readability: Is the code easy to read and follow? If not are there comments to help understand the code?
- Maintainability: Can this code be easily maintained or extended in the future?
Functionality
- Correctness: Does the code meet the requirements of the task?
- Impact on Existing Functionality: Has the impact on existing functionality been considered and tested?
Testing
- Test Coverage: Are unit tests provided for new or modified code?
- Test Results: Have all tests passed?
Documentation
- Documentation: Are both inline and applicable external documentation updated and clear?
Pull Request Details
- PR Description: Is the problem being solved clearly described?
- Checklist Completion: Have all relevant checklist items been reviewed and completed?
|
|
|
Will add cards to the planner for the following so this PR doesn't become too convoluted:
|
a38d03a to
652bdff
Compare
Rhinoatron
left a comment
There was a problem hiding this comment.
Great work on this fix. I’ve completed the second peer review and confirmed that resetting both camera coordinates before closing the window prevents the camera state from affecting later tests. The change is clear, appropriately scoped, and the first peer reviewer has also confirmed it works successfully with sktest. The other test issues have been kept separate so this PR remains focused. Approved.
Description
Fixed error at the end of the camera test where the x and y position would not be reset if moved. This was causing the problem of other tests not having the camera centered.
I have found another problem in the bundles test that is causing two bundles to incorrectly not be freed. There is no fix yet for that but I will update the pull request with any fixes.There is another PR that fixes this problem #153Type of change
How Has This Been Tested?
The changes are being tested with sktest to make sure the correct results and
Testing Checklist
Checklist