Split LinkGeneratedSources config into LinkGeneratedSourcesOnBuild and GeneratedSourcesLinkType (#3513)#3516
Open
Dimagog wants to merge 1 commit intothought-machine:masterfrom
Conversation
…` and `GeneratedSourcesLinkType` (thought-machine#3513) The existing `LinkGeneratedSources` string field conflates two concerns: whether to link during builds, and what link type to use. This makes it impossible to use hard links only during `plz generate` without also auto-linking during builds. Add two new config fields: - `LinkGeneratedSourcesOnBuild` (bool): controls auto-linking during builds - `GeneratedSourcesLinkType` ("soft"/"hard"): controls link type The old field is deprecated. When set, it is normalised into the new fields at config load time with a warning. Setting both old and new fields is an error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing
LinkGeneratedSourcesstring field conflates two concerns: whether to link during builds, and what link type to use. This makes it impossible to use hard links only duringplz generatewithout also auto-linking during builds.Add two new config fields:
LinkGeneratedSourcesOnBuild(bool): controls auto-linking during buildsGeneratedSourcesLinkType("soft"/"hard"): controls link typeThe old field is deprecated. When set, it is normalised into the new fields at config load time with a warning. Setting both old and new fields is an error.
Tests:
plz_generatee2e tests pass