thcrap_update: Use enum class, using rather than typedef, fix throw#311
Open
mikomikotaishi wants to merge 2 commits into
Open
thcrap_update: Use enum class, using rather than typedef, fix throw#311mikomikotaishi wants to merge 2 commits into
mikomikotaishi wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to address the following:
enum) rather thanenum class, which is more consistently used in thcrap_update; we could switch to these for type safety.typedefs overusingaliases in C++, andusingstatements are much cleaner.throw new invalid_argument()was used, which is not only an unnecessary heap allocation but even a source of memory leaks.constreference is safer as it avoids unnecessary copies and avoids object slicing risks entirely.static_cast<T>(x)is safer than using a C-style cast ((T)x).