Skip to content

StorageTextureNode: Tighten types & add store function#2150

Merged
Methuselah96 merged 3 commits into
three-types:masterfrom
thelazylamaGit:StorageTextureNode-typesUpdate
May 23, 2026
Merged

StorageTextureNode: Tighten types & add store function#2150
Methuselah96 merged 3 commits into
three-types:masterfrom
thelazylamaGit:StorageTextureNode-typesUpdate

Conversation

@thelazylamaGit
Copy link
Copy Markdown
Contributor

Modifies StorageTextureNode.d.ts to type value as StorageTexture instead of Texture to better match the three.js definitions and also adds new type declaration for .store() function added in this PR mrdoob/three.js#33544

@thelazylamaGit
Copy link
Copy Markdown
Contributor Author

thelazylamaGit commented May 12, 2026

test-examples seems to be failing because its inferring the js Fn(({ storageTexture }) => ...) as Texture, not StorageTexture.

StorageTexture | StorageTextureNode better matches the JSDoc & should be more accurate here, but Texture | StorageTextureNode avoids this inference error and should still work anyways. I'll leave choice up to whatever maintainer thinks is better.

Copy link
Copy Markdown
Contributor

@Methuselah96 Methuselah96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Methuselah96 Methuselah96 merged commit 7bf5bcb into three-types:master May 23, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants