Added Catppuccin theme in settings and updated Readme

[ZiClaud]

The readme now doesn't have the link to the mobile app, since it does't work, but has a link to the website

---

The screenshoots show the theme changes

Could be improved in the future, and there's a bug where on reload it shows "Activate Catpuccin theme", even when it's already on

---

I've also changed a couple of lines in the main setup 'cause the local build did't work for me:

const dirName = process.resourcesPath ? path.join(process.resourcesPath, "app") : process.cwd();

to

const dirName = app.isPackaged ? path.join(process.resourcesPath, "app") : process.cwd();

[thuiop]

Hi, thanks for the contribution! (and sorry for the late reply, I have been fairly busy this past week)

I have been wondering about adding themes, but have not worked towards it as my graphical skills are not very sharp. I think it makes sense to have a choice of themes; however if we go that way I think this should be a dropdown list instead (with Classic and Catpuccin), which will be more extensible than adding a button. Similarly, there should likely be a theme cookie containing the name of the theme rather than a boolean. But great addition otherwise.

Also, the README update could have been a separate PR (but that is fine). Regarding your issue with running it locally, what was the error message? It might be a matter of correctly checking the type of process.resourcePath instead of its truthiness. I would prefer to do it that way as it would directly relate to what happens in the ternary, rather than being a third-party value with non-obvious relevance.

[ZiClaud]

and sorry for the late reply, I have been fairly busy this past week

Don't you worry, I've been quite busy myself, and I've also disappeared for a year or two

I think it makes sense to have a choice of themes; however if we go that way I think this should be a dropdown list instead

That's a wonderful idea! I'll start working on it as soon as I find the time

Also, the README update could have been a separate PR

Didn't know/forgot about that. I'd suggest you create a CONTRIBUTING.md like this one here. If you want I can create one with "Just one pull request for each feature/issue" and and "how to build" guide (like the few "build" lines I've added in the readme). But I've never created one before.

Regarding your issue with running it locally, what was the error message?

Consider I'm on Linux Fedora

ziclaud@fedora-slimbook:~/Desktop/GitHub/magium-dev$ npm run start:electron

> MagiumJS@0.9.6 start:electron
> electron .

App threw an error during load
Error: Cannot find module '/home/ziclaud/Desktop/GitHub/magium-dev/node_modules/electron/dist/resources/app/data/locales.json'
Require stack:
- /home/ziclaud/Desktop/GitHub/magium-dev/src/main_setup.js
- /home/ziclaud/Desktop/GitHub/magium-dev/main_electron.js
    at Module._resolveFilename (node:internal/modules/cjs/loader:1232:15)
    at s._resolveFilename (node:electron/js2c/browser_init:2:123244)
    at Module._load (node:internal/modules/cjs/loader:1058:27)
    at c._load (node:electron/js2c/node_init:2:16955)
    at Module.require (node:internal/modules/cjs/loader:1318:19)
    at require (node:internal/modules/helpers:179:18)
    at Object.<anonymous> (/home/ziclaud/Desktop/GitHub/magium-dev/src/main_setup.js:35:15)
    at Module._compile (node:internal/modules/cjs/loader:1484:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1564:10)
    at Module.load (node:internal/modules/cjs/loader:1295:32)
A JavaScript error occurred in the main process
Uncaught Exception:
Error: Cannot find module '/home/ziclaud/Desktop/GitHub/magium-dev/node_modules/electron/dist/resources/app/data/locales.json'
Require stack:
- /home/ziclaud/Desktop/GitHub/magium-dev/src/main_setup.js
- /home/ziclaud/Desktop/GitHub/magium-dev/main_electron.js
    at Module._resolveFilename (node:internal/modules/cjs/loader:1232:15)
    at s._resolveFilename (node:electron/js2c/browser_init:2:123244)
    at Module._load (node:internal/modules/cjs/loader:1058:27)
    at c._load (node:electron/js2c/node_init:2:16955)
    at Module.require (node:internal/modules/cjs/loader:1318:19)
    at require (node:internal/modules/helpers:179:18)
    at Object.<anonymous> (/home/ziclaud/Desktop/GitHub/magium-dev/src/main_setup.js:35:15)
    at Module._compile (node:internal/modules/cjs/loader:1484:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1564:10)
    at Module.load (node:internal/modules/cjs/loader:1295:32)

Changing those 2 lines fixed the issue

[ZiClaud]

[thuiop]

Thanks! I will look into your changes in the coming days.

[thuiop]

I took a look at the electron issue, I could reproduce it indeed. However, your fix broke the web server version. I came up with another fix which I committed to the main branch and rebased your branch against it.

[ZiClaud]

Sounds good, just tested it and it works for me, thx

[thuiop]

Hi, I finally had the time to properly look at this. Overall this is a pretty good job, there were just a few details to iron out. Thanks for the contribution!