Vite, TypeScript and ESLint updates and housekeeping#274
Conversation
davinotdavid
left a comment
There was a problem hiding this comment.
Commenting only for now as I am not super familiar with the history / reason of our configs.
I think I need to read a bit more about the tsconfig / vite config options as I am not entirely sure why we need all the config we currently use but also running npm run build outputs this in my machine:
❯ npm run build
> @thunderbirdops/services-ui@1.6.2 build
> vite build --
vite v8.0.11 building client environment for production...
✓ 126 modules transformed.
[unplugin:dts] Start generate declaration files...
[unplugin:dts] Start bundling declaration files...
[unplugin:dts] Failed to load '@microsoft/api-extractor', have you installed it?
[unplugin:dts] Error occurred, skip bundle declaration files.
[unplugin:dts] Declaration files built in 1089ms.
I seems to still produce an output but again I wonder if we can simplify our setup further so we can have more smoother dependency package updates in the future.
Thanks so much for this catch. Should be fixed now. I reverted some of the changes and set
Yes, I would appreciate this. However, splitting tsconfig into main, app and node seems to be the recommended way 🤔 At least this is what vue-create and other project init processes generate. @MelissaAutumn Do you have any input on this? |
What changed?
This change maintains package dependencies. In particular, the following packages got a major upgrade:
Viteto v8TypeScriptto v6ESLintto v10All other packages got minor or patch updates.
eslint-plugin-importgot removed (imho not needed anymore and incompatible to ES 10).Furthermore, the
tsconfig*files were changed to their common default values for migration purposes to TS 6. Please review that carefully and let me know, if I missed something here.Also type errors were fixed and linting issues. All changes were kept at minor level, no breaking change was introduced intentionally.
All changes were tested. Linting, Building and Storybook work as intended locally for me. But please test and confirm this.
Applicable Issues
Fixes https://github.com/thunderbird/services-ui/security/dependabot/54, https://github.com/thunderbird/services-ui/security/dependabot/55 and https://github.com/thunderbird/services-ui/security/dependabot/56
Closes #273