[BACK-4088] Bump go version to 1.25.x.#898
Merged
lostlevels merged 1 commit intomasterfrom Apr 6, 2026
Merged
Conversation
toddkazakov
previously approved these changes
Jan 9, 2026
lostlevels
force-pushed
the
jimmy-go-125
branch
4 times, most recently
from
7a9e9e3 to
5e18542
Compare
lostlevels
changed the title
lostlevels
force-pushed
the
jimmy-go-125
branch
from
ee2cfea to
d7787f1
Compare
darinkrauss
approved these changes
Mar 27, 2026
Contributor
darinkrauss
left a comment
darinkrauss
left a comment
There was a problem hiding this comment.
LGTM, with one curiosity question.
| go work edit -use=./private/plugin/$(PLUGIN) && \ | ||
| go work edit -go=`sed -n 's/^go //p' go.mod` && \ | ||
| go work edit -toolchain=`sed -n 's/^toolchain //p' go.mod` && \ | ||
| go work edit -toolchain=`grep -q '^toolchain' go.mod && sed -n 's/^toolchain //p' go.mod || sed -n 's/^go /go/p' go.mod` && \ |
Contributor
There was a problem hiding this comment.
Just curious - what is this change for?
Contributor
Author
There was a problem hiding this comment.
go mod tidy for me removed the toolchain go... in the go.mod so the go work edit -toolchain= call would have an empty value causing the build to fail so this was added in case someone else's run of go mod tidy adds it back.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.