GML-2131: Respect configured TigerGraph ports during UI login#44
Merged
chengbiao-jin merged 1 commit intoJun 23, 2026
Merged
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
01d1bc0 to
2319b01
Compare
2319b01 to
59ab0aa
Compare
chengbiao-jin
approved these changes
Jun 23, 2026
chengbiao-jin
added a commit
that referenced
this pull request
Jun 23, 2026
* GML-2132 Add knowledge graph compatibility check and repair - Scan an existing graph for installed queries that have drifted from the shipped version or are missing - Repair them in place without rebuilding the knowledge graph - Refuse repair while a rebuild is in progress and run it under the per-graph lock * GML-2133 Harden document ingestion and unify vertex ID handling - Reconcile chunks left unfinished by an interrupted run before processing new documents - Write each chunk together with its content so cancellation can't leave chunks without content - Normalize vertex IDs the same way across every ingest path so documents with spaces or mixed case in filenames stay consistent - Re-create installed queries that have drifted from the shipped version on initialization - Surface ingestion failures as clear errors instead of failing silently * GML-2134 Report per-file upload failures in the ingestion dialog * GML-2135 Release 1.4.2 - Bump version to 1.4.2 - Update CHANGELOG and README releases - Add .gitignore - GML-2131 Honor configured GS/RESTPP ports at login * GML-2131: Respect configured TigerGraph ports during UI login (#44) * GML-2131 Guard configured ports in role-resolution connection - Omit gsPort/restppPort unless configured, matching the auth() path, so absent config falls back to pyTigerGraph defaults * GML-2133 Refine ingestion changes per review - Restore partitioned batch streaming for documents and chunks - Check vertex existence through the TigerGraph client instead of hand-built requests - Use lowercase document ids consistently across the batch ingest path --------- Co-authored-by: omarAyoubi <94470413+OmarAyo1@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
PR Type
Bug Fix
Description
Respect configured TigerGraph
gsPortandrestppPortduring UI loginFix
/ui/ui-loginincorrectly falling back to pyTigerGraph default RESTPP port9000Apply the same connection port configuration to both username/password and API-token login paths
Prevent valid TigerGraph credentials from being rejected when TigerGraph is exposed on a non-default port such as
14240Diagram Walkthrough
File Walkthrough
Relevant files
Bug Fix 1 file
graphrag/app/routers/ui.pyPass configured TigerGraph gsPort/restppPort into UI login TigerGraphConnection callsValidation
Reproduced the issue with TigerGraph exposed on port
14240Confirmed
TigerGraphConnection(..., gsPort=14240, restppPort=14240)succeeds with the same credentialsConfirmed the existing
/ui/ui-loginpath fails because it falls back to port9000Confirmed
/ui/ui-loginreturns200 OKafter passing configuredgsPortandrestppPortPR Type
Bug fix
Description
Pass configured ports to UI login
Fix non-default TigerGraph port authentication
Diagram Walkthrough
File Walkthrough
ui.py
Configure TigerGraph ports for UI authenticationgraphrag/app/routers/ui.py
gsPortfromdb_configto UI login connectionsrestppPortfromdb_configto UI login connections