tests: cover run_vulkan.sh release-path fallback behavior#38
Draft
cursor[bot] wants to merge 1 commit intonext-gen-5from
Draft
tests: cover run_vulkan.sh release-path fallback behavior#38cursor[bot] wants to merge 1 commit intonext-gen-5from
cursor[bot] wants to merge 1 commit intonext-gen-5from
Conversation
Co-authored-by: Tim Fox <timfox@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add deterministic regression coverage for
scripts/run_vulkan.shengine path resolution logic introduced in recent merged changes.Risky behavior now covered
scripts/run_vulkan.shfrom repositoryscripts/must execute engine binaries from siblingrelease/directory.run_vulkan.shfrom insiderelease/must still resolve and execute local engine binaries.idtech3vsidtech3.aarch64) must route correctly and preserve passthrough args.Test files added/updated
tests/scripts/test_run_vulkan_path_resolution.shCMakeLists.txttest_run_vulkan_path_resolution(labels:unit;scripts;validation).Why this materially reduces regression risk
Recent production behavior changed in a startup script used to launch the Vulkan client. Incorrect path resolution causes immediate startup failures in real deployments (repo-runner vs copied-script layouts). This test locks both supported layouts and architecture-dependent selection with deterministic assertions, preventing silent breakage in a high-blast-radius launch path.
Validation run
tests/scripts/test_run_vulkan_path_resolution.sh scripts/run_vulkan.shctest -R test_run_vulkan_path_resolution --output-on-failure(frombuild-dbg)Both passed in this environment.