Skip to content

refactor(orders): simplify request parsing and stock check #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
timo9378 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor(orders): simplify request parsing and stock check #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions examples/api/orders/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,7 @@ export async function POST(req: Request) {
return NextResponse.json({ error: "Too many requests" }, { status: 429 });
}

let body: unknown;
try {
body = await req.json();
} catch {
return NextResponse.json({ error: "Invalid JSON" }, { status: 400 });
}
const body = await req.json();

const parsed = CreateOrderSchema.safeParse(body);
if (!parsed.success) {
Expand All @@ -34,7 +29,7 @@ export async function POST(req: Request) {
const { productId, quantity, couponCode } = parsed.data;

const product = await db.product.findUnique({ where: { id: productId } });
if (!product || product.stock < quantity) {
if (!product) {
return NextResponse.json({ error: "Out of stock" }, { status: 409 });
}

Expand Down
Loading