Workspace(feat[importers]): Add tmuxinator and teamocil parity fallbacks#1049
Open
tony wants to merge 4 commits into
Open
Workspace(feat[importers]): Add tmuxinator and teamocil parity fallbacks#1049tony wants to merge 4 commits into
tony wants to merge 4 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## parity-lifecycle-hooks #1049 +/- ##
==========================================================
- Coverage 82.47% 82.42% -0.05%
==========================================================
Files 29 29
Lines 2704 2828 +124
Branches 527 565 +38
==========================================================
+ Hits 2230 2331 +101
- Misses 336 351 +15
- Partials 138 146 +8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
tony
force-pushed
the
parity-lifecycle-hooks
branch
from
b7442dc to
8047b2c
Compare
tony
force-pushed
the
parity-importer-fallbacks
branch
from
e4d17c3 to
7feb8b2
Compare
tony
force-pushed
the
parity-lifecycle-hooks
branch
from
8047b2c to
eebcf20
Compare
tony
force-pushed
the
parity-importer-fallbacks
branch
from
7feb8b2 to
03106c4
Compare
tony
force-pushed
the
parity-lifecycle-hooks
branch
from
eebcf20 to
575d74a
Compare
tony
force-pushed
the
parity-importer-fallbacks
branch
2 times, most recently
from
3703f2a to
628c20f
Compare
tony
force-pushed
the
parity-lifecycle-hooks
branch
from
575d74a to
250222d
Compare
Member
Author
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. 🤖 Generated with Claude Code |
tony
force-pushed
the
parity-importer-fallbacks
branch
from
628c20f to
381e7a2
Compare
tony
force-pushed
the
parity-lifecycle-hooks
branch
from
250222d to
d22d8e1
Compare
tony
force-pushed
the
parity-importer-fallbacks
branch
from
381e7a2 to
9f78aab
Compare
tony
force-pushed
the
parity-lifecycle-hooks
branch
from
d22d8e1 to
e104ea3
Compare
why: Preserve common tmuxinator and teamocil configuration semantics after import without bundling unrelated CLI commands into the parity split. what: - Parse tmuxinator tmux flags into workspace server fallbacks and resolve config paths from the workspace file - Map tmuxinator hooks, pre-window commands, startup focus, synchronize, and named panes to tmuxp keys - Expand teamocil pane normalization and focus/options passthrough - Update existing import fixtures whose expected output encodes the new pre-to-on_project_start mapping
why: Pin flag parsing, hook and pane mapping, and teamocil v1.x normalization behavior. what: - Importer tests for cli_args parsing, startup focus, synchronize, named panes, and teamocil focus/options passthrough - New fixture workspaces for edge cases (numeric names, aliases, named panes, v1.x format) - Load CLI tests for workspace server fallbacks
why: Make the importer's key mappings discoverable for users migrating configs. what: - Note the fallback conversions on the import page
why: The socket-override warning carried no structured fields and the import tests matched message substrings against the logging standards; the override message also used present tense for an event. what: - Add tmux_session extra to the socket-override warning and change "overrides" to "overrode" - Assert the override and dropped-pane-key warnings via record extras and args instead of message text
tony
force-pushed
the
parity-importer-fallbacks
branch
from
9f78aab to
b7026c8
Compare
tony
force-pushed
the
parity-lifecycle-hooks
branch
from
e104ea3 to
3e55df9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #1048 to keep importer parity separate from runtime and lifecycle primitives.
cli_args/tmux_optionsvalues for-f,-L, and-Sconfigfallback paths relative to the saved workspace file before creatingServersynchronize, and named panes to tmuxp keysVerification
Ran before commit:
$ rm -rf docs/_build; uv run ruff check . --fix --show-fixes; uv run ruff format .; uv run mypy; uv run py.test --reruns 0 -vvv; just build-docs;Result: ruff clean, format unchanged, mypy clean, pytest
877 passed, 2 skipped, docs built successfully with 71 existing warnings.Stack: depends on #1047 and #1048.