fix(druid): add JSON_VALUE RETURNING support#7771
Merged
georgesittas merged 1 commit intoJun 20, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
JSON_VALUEto Druid'sFUNCTION_PARSERSso theRETURNING <type>clause is parsed instead of falling through to the generic function-call parser, which can't handle it.The base
Parser._parse_json_valuealready handlesRETURNING(andON EMPTY/ON ERROR) correctly — it just wasn't routed for the Druid dialect. MySQL, Trino, and Exasol registerJSON_VALUEthe same way.Before
After
Related
Surfaced via apache/superset#36954 — Superset users on Druid datasets currently can't run any query using
json_value(..., '$.x' RETURNING <type>)because the SQL fails sanitize/format before being sent to the engine.Tests
Added
test_json_valuetotests/dialects/test_druid.pycovering plainJSON_VALUE,RETURNING DOUBLE, and the exact failure case from the linked issue. Full suite (python -m unittest) green locally.