Add node22 support#1
Merged
Merged
Conversation
Add an operator-managed node22 base image (digest-pinned node:22-alpine + bash/git/build-base/python3 + corepack with yarn 1.22.22 and pnpm 10.34.5 pre-activated for offline resolution under readOnlyRootFilesystem), selectable via spec.pipeline.nodeVersion: 22. Wire it through every consumer the image-set drift guard enforces: images/Makefile (build target + pinned base digest), the CI docker_build matrix, the release-body image loop, the chart's operator.nodeImages values, the rendered helm snapshots, and the check-images drift-test fixture. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
pnpm builds set npm_config_modules_dir=/cache/node_modules, relocating node_modules onto the cache PVC. But `pnpm exec`/`pnpm run` resolve a command's bin from <cwd>/node_modules/.bin (cwd-relative), NOT from modules-dir — so any phase running an installed tool (e.g. `pnpm exec graphql-codegen` in a fetch codegen step) failed "command not found". Drop npm_config_modules_dir and keep only the content-addressable store on the cache PVC (npm_config_store_dir). node_modules now lands on the per-run /work emptyDir for pnpm too (same as yarn), shared across the pod's init containers, so cwd-relative bin resolution works in every phase while the store still gives cross-run install speedup. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…mental builds The build phase mounted the dataCache read-only, so an app that persists an incremental-build working tree there (e.g. astro-incremental via a `build -> /data` symlink) failed `mkdir build/incremental` (EROFS/ENOENT). Mount the dataCache RW in the build phase so the build can write its cache and prior output back for reuse across runs, and mount it RO on the copier so it can follow a symlinked outputDir (build/out -> /data/out) when publishing the bundle. This does not widen the credential boundary: that invariant is about the fetch script never writing secrets into the dataCache (readable by build's untrusted deps), which RW-vs-RO in build does not change. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
thenav56
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.