Refactor encoding check as per brotli module#43
Open
robvanoostenrijk wants to merge 1 commit into
Open
Conversation
Contributor
Can you point the issue with the response? I cannot pin point it. |
Author
Even though the request sets This is mostly an issue with dynamically generated nginx content, static pages and/or files work fine in the original code. |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using zstd-nginx-module with the following configuration, does not work on for example
autoindexgenerated documents.This request returns the following on request:
Updating the logic where the filter determines if its going to compress the response, aligning to what Google ngx_brotli uses, resolves the above issue.
Additionally lifting out the request check function to a shared code file ensures the logic is identical for both static and dynamic filters.