Improve error message for files that exceed 5 GiB#380
Merged
Conversation
don-vip
approved these changes
May 15, 2026
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Commons doesn't allow files over 5 GiB to be uploaded, and to enforce this we have used
ulimit -fto restrict the size of output files to 5 GiB so that no attempt is made to upload files that exceed the cap. However, the default error message for exceeding this limit (Exitcode: 153) is very confusing to users and doesn't tell them what they need to do in order to solve the error. This patch improves the error message for these kinds of errors.Changes
Exitcode: 153errors.background_size_limitis set to its current value via a comment.Screenshot