perf: pool HMM (kofam/sulfur) via -T bit-score prefilter [HOLD until campaign done]#12
Draft
tpall wants to merge 4 commits into
Draft
perf: pool HMM (kofam/sulfur) via -T bit-score prefilter [HOLD until campaign done]#12tpall wants to merge 4 commits into
tpall wants to merge 4 commits into
Conversation
On branch perf/hmm-pool-bitscore (experiment, NOT for PR #10). Re-enables kofam/sulfur pooling + chunking (un-reverts 3457a80) and switches hmmsearch from the e-value prefilter (-E, scales with search-space size Z) to a bit-score prefilter (-T 10 --domT 10). Bit scores are Z-independent, so pooled multi-genome hmmsearch reports the SAME hits as per-genome; hmm_parser still applies per-profile bit-score thresholds. Floor 10 < lowest kofam threshold (15.07), so no real hit is pre-cut. Goal: validate per-genome(-T) == pooled(-T) on extraves (proves -T removes the Z-dependence that made -E pooling churn ~5% of kofam calls). NB changes results vs -E, so a future pipeline-wide decision, not mid-campaign. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…validated) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
perf: pool HMM (kofam/sulfur) via Z-independent bit-score prefilter (-T)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
⛔ HOLD — do not merge until the current eluring campaign finishes
The 3 finished cohorts (samples_65_74_new, samples_12_18_new, dengl2025) and the in-flight ones (chulenbayeva → wu_rampelli → sajased-aftekas → curated_metagenomic) all run on the
-Eper-genome path. Merging this changes HMM (kofam/sulfur) output (-E→-T, +0.08% kofam), so it must wait until the campaign is done — then it becomes the default for the next campaign (everything-T-pooled, consistent from the start).Why this PR exists
PR #11 was stacked on
perf/search-bundlingand merged into that branch after PR #10 had already mergedperf/search-bundling → dev. So #11's HMM commits never reacheddev. This PR brings them in: it's exactly the 4 commitsperf/search-bundlingis ahead ofdev:What it does
Adds HMM (kofam/sulfur) to
--pool_searchesby switchinghmmsearchfrom the Z-dependent e-value prefilter to a Z-independent bit-score prefilter:hmm_parseralready filters on per-profile bit-score thresholds, so-Ewas the only search-space-size-dependent step.10sits below kofam's lowest profile threshold (15.07), so nothing a real threshold would keep is pre-cut. Bit score is identical alone vs pooled, so pooled HMM == per-genome HMM.Validation (extraves)
per-genome(
-T) vs pooled-chunked(-T), all 5 DBs:RESULT: IDENTICAL(141270 rows; kofam fanned to 8 chunks). With this, the entire annotation path (mmseqs + HMM) pools byte-identically.-E: +63 kofam calls (~0.08%) — the bit-score-significant hits-E 1e-5silently dropped (arguably a latent-bug fix).-Z/--domZdoesn't work for a multi-genome pool (one-Zcan't match variable per-genome sizes).docs/dev/search-bundling.md.🤖 Generated with Claude Code