Remove the stale requirements/*.txt glob from the CI cache key#394
Open
tpvasconcelos wants to merge 2 commits into
Open
Remove the stale requirements/*.txt glob from the CI cache key#394tpvasconcelos wants to merge 2 commits into
tpvasconcelos wants to merge 2 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #394 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 19 19
Lines 674 674
Branches 88 88
=========================================
Hits 674 674
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Small cleanup left over from #388: the
requirements/directory no longer exists (all development dependencies now live in PEP 735 dependency groups inpyproject.toml), but thesetup-pythoncomposite action still listedrequirements/*.txtin setup-uv'scache-dependency-glob. This removes the dead glob so the cache key is derived frompyproject.tomlalone, and updates the (stale)-r requirements.txtexample in therequirementsinput description.No behaviour change expected: the glob matched nothing, so cache keys stay the same.
Related issues
Related to #219 (follow-up to #388).
PR check list
docs/reference/changelog.md.📚 Documentation preview 📚: https://ridgeplot--394.org.readthedocs.build/en/394/