[pull] master from golang:master#47
Merged
Merged
Conversation
Change-Id: I63cdd2bcb855be6f799aa5ddf461b1dd6a6a6964 Reviewed-on: https://go-review.googlesource.com/c/go/+/780481 Reviewed-by: Roland Shoemaker <roland@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Auto-Submit: Filippo Valsorda <filippo@golang.org> LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Mostly an attempt at understanding the new compiler behavior. Also, replace some deprecated ioutil calls with os calls. Follow-up on CL 706795. Change-Id: Ia626cc44a4188674bb8f21bf9a0c207c6b1a10b1 Reviewed-on: https://go-review.googlesource.com/c/go/+/779983 Reviewed-by: Robert Griesemer <gri@google.com> Auto-Submit: Robert Griesemer <gri@google.com> Reviewed-by: Neal Patel <nealpatel@google.com> LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
This allows us to avoid calling mallocgcSmallScanNoHeader when sizespecializedmalloc is enabled, reducing binary size. Change-Id: I16b98bac06eccd42b3c146f3b829aae96a6a6964 Reviewed-on: https://go-review.googlesource.com/c/go/+/780700 Auto-Submit: Michael Matloob <matloob@golang.org> Reviewed-by: Michael Pratt <mpratt@google.com> Reviewed-by: Michael Matloob <matloob@google.com> LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Currently, when static initializes a variable with a struct literal, the compiler uses the field's offset in its containing struct. This is usually correct, except that with the newly- allowed direct access of embedded field, the offset does not include the offset of the embedded type in its containing type. We need to include all the implicit field offsets in the offset calculation. For #9859. Change-Id: Ifa4fae77383d912fba2638538248b06a3c286373 Reviewed-on: https://go-review.googlesource.com/c/go/+/780220 LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Robert Griesemer <gri@google.com>
runtime_readTrace is not used anywhere. And the linknamed target does not exist in the runtime package. Remove. Change-Id: I108d556facfefe6c7a59c37c039b3f2f8bcdb5b7 Reviewed-on: https://go-review.googlesource.com/c/go/+/780921 LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: David Chase <drchase@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )