[pull] master from golang:master#48
Merged
Merged
Conversation
For some reason, aggressive inlining with -l=4 during TestAbstractOriginSanity does not properly analyze ftoa[F] and concludes that dst escapes to the heap. An earlier CL disabled TestAbstractOriginSanity to fix the build. This CL re-enables TestAbstractOriginSanity and manually specializes ftoa[F] into ftoa32 and ftoa64, which avoids the bad escape analysis and lets us re-enable the test. For #79547. Change-Id: I5a87ef5c95761781b9fea2b22d2bb161e37897d5 Reviewed-on: https://go-review.googlesource.com/c/go/+/781160 TryBot-Bypass: Russ Cox <rsc@golang.org> Reviewed-by: David Chase <drchase@google.com> Reviewed-by: Michael Pratt <mpratt@google.com> Reviewed-by: Cherry Mui <cherryyz@google.com>
Internal scanning tools think we are using text/template for generating YAML. We are not, we are using it for generating Go code, which is reviewed before being checked in. The internal tooling must be quieted, so I've annotated the text/template import. I don't think leaking these internal abstractions, but we don't have much choice unfortunately. Change-Id: Ie6dfa27bf4f4b5df8dbd492ae95b474f8145e745 Reviewed-on: https://go-review.googlesource.com/c/go/+/774480 Reviewed-by: Austin Clements <austin@google.com> Reviewed-by: Cherry Mui <cherryyz@google.com> LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
We won't be able to unzip something with 2^32-1 bytes in it. Fixes the linux/386 longtest builder. Fixes #79554 Fixes #79555 Change-Id: Ifbff124412a007fb00cf5e7c99c1050b17f190d0 Reviewed-on: https://go-review.googlesource.com/c/go/+/780980 Auto-Submit: Keith Randall <khr@golang.org> Reviewed-by: Junyang Shao <shaojunyang@google.com> Reviewed-by: Keith Randall <khr@google.com> LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Update vendored x/arch repo to 9c1a596, to bring in the support of AVX instructions in the disassembler. Done by cd GOROOT/src/cmd go get golang.org/x/arch@master go mod tidy go mod vendor Fixes #78065. Change-Id: Ie37b9e1ac57f9c8617d2613de164874ed8cb3a8c Reviewed-on: https://go-review.googlesource.com/c/go/+/781281 TryBot-Bypass: Cherry Mui <cherryyz@google.com> Reviewed-by: David Chase <drchase@google.com>
Derived from CL 775100 by qiu laidongfeng <2645477756@qq.com> Fixes #77853 Change-Id: Iefcdbd1a7dbf82e732dad9bbf94722878c82c1a6 Reviewed-on: https://go-review.googlesource.com/c/go/+/780582 Reviewed-by: qiu laidongfeng <2645477756@qq.com> Reviewed-by: Mark Freeman <markfreeman@google.com> LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Auto-Submit: Austin Clements <austin@google.com>
Change-Id: I1adcbd84d81bb7d0f099ce729ec386b46a6a6964 Reviewed-on: https://go-review.googlesource.com/c/go/+/780480 Auto-Submit: Filippo Valsorda <filippo@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Junyang Shao <shaojunyang@google.com> LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
This change causes the vet and fix tools to take their inventory of analyzers from the published suite constants in x/tools. This will make it easier for others to make their own tools that track these suites with minor variations. Also, vendor x/tools@6923890 (master). For #35487 Change-Id: Iafcd256999cc98caa40ad60a463182abd892dc27 Reviewed-on: https://go-review.googlesource.com/c/go/+/780900 Reviewed-by: Mark Freeman <markfreeman@google.com> Auto-Submit: Alan Donovan <adonovan@google.com> LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )