Implement parameter substitution for migrations#3847
Closed
krlohnes wants to merge 21 commits into
Closed
Conversation
This commit adds the actual processing of template parameters for migrations. It also switches over `args` for `parameters` to be more in line with the nomenclature in the issue
Was treating it like it did, so it wasn't working
- Restored parameter support in migrate macro while maintaining compatibility with main branch API - Fixed test code to use SqlStr instead of Cow<String> for SQL migration content - All parameter processing tests now pass: - test_migration_process_parameters_with_substitution - test_migration_process_parameters_no_substitution - test_migration_process_parameters_missing_key - test_migration_process_parameters_missing_key_with_default_value - UI tests for parameter validation also pass - Migration functionality works with both simple path and parameter-based approaches
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does your PR solve an issue?
fixes #3178
Is this a breaking change?
No. The addition of fields to the Migrator is semver exempt, The MigrateError enum is
#[non-exhaustive]. The new macro functionality retains the existing functionality of the crate and should be backward compatible. I'm making the assumption that changes to the function signatures of sqlx-cli are not considered breaking, but please correct me if I'm wrong there.