perf(clickhouse): add task_events_v2 inserted_at minmax index - #4620
Conversation
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📜 Recent review details⏰ Context from checks skipped due to timeout. (8)
WalkthroughAdds a Goose migration that creates the 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The testcontainers migration parser splits Up statements on ';', including semicolons inside comments, which produced a comments-only fragment rejected by ClickHouse as 'Empty query.'
Adds a
minmaxskip index ontask_events_v2.inserted_at(idx_inserted_at_projector) to support bounded, closed time-window scans of the source table.ADD INDEXonly defines the index for newly written parts; existing parts are not materialized. New parts (e.g. after the next UTC partition boundary) will carry it.Split out ahead of the larger log-search-v2 work so the index can be deployed independently for read-path testing.