docs(todo): 1a measured (not a bug), 1b fixed (#97) - #98
Merged
Conversation
1a: an idle WS connection is NOT torn down at 15s — measured against a running server, the keepalive PING arrives at ~30s and the connection stays open past 75s, so setReadTimeout(15) does not apply after the upgrade. 1b: the board-bootstrap defect is fixed; what remains is the ordering half, which is 1d's per-message cursor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Records two resolutions in
dev/TODO.mditem 1.setReadTimeout(15)kill an idle WS connection at 15s, before the 30s ping?) is now measured: against a running server, an idle no-inbound WS connection got its keepalive PING at t≈29.7s and stayed open past 75s — no teardown at 15s. So the read timeout does not apply to a WebSocket after the upgrade, and the extension's own ping keeps an idle connection alive. Not a bug; nothing to fix.seqto de-dupe by), which is 1d's per-message cursor, not more bootstrap.Doc-only. No code change.