Fix #79: remove extra net label in repro case#273
Open
irisdigitaldocs-maker wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Add the complete repro tscircuit#79 fix from an Iris-owned branch: skip label-only nets in MSP and long-distance routing, update snapshots, add regression tests, and include demo proof assets.\n\n/claim tscircuit#79
irisdigitaldocs-maker
force-pushed
the
fix/79-extra-net-label-final
branch
from
d6376d7 to
b32e0bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Pins connected only via
netConnections(net labels like VCC/GND, with no direct wire between the pins) were still being considered for long-distance routing. That produced physical trace lines for label-only nets, which is the extra net-label/repro #79 behavior.Fix
This PR keeps the existing MSP net-label filtering fix and adds the long-distance routing side of the fix:
netConnections.docs/repro79-demo.svgdocs/repro79-demo.mp4Tests
bun run format:check✅bunx tsc --noEmit✅bun test✅/claim #79