Make light menu logic consistent with DELTARUNE#39
Open
krisgrant wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes make tldr's light world menu I think 100% accurate to how it works in DELTARUNE by changing:
In DELTARUNE, snd_ui_move is played if when moving between menus the selected option in the currently entered menu is not the same selection number as the menu you are entering. It's also played when opening the lw menu and of course when moving between options in those menus, unless you have reached either end of those options.
The currently selected option is saved when closing and reopening the menu the same way it is in the dark world menu.
From what I've seen, trying to open the item menu when it's disabled doesn't play any sound unlike in tldr.
When opening the cell menu in DELTARUNE, if there are no phone numbers, it will simply place the soul in the spot where it would be if the first option was selected, with no further interactivity being available in the menu.
These are all the inaccuracies I've noticed in my experience with experimenting with this menu, feel free to point out anything wrong here.