create Spark 4.1 and 4.2 support and fix unit tests - #966
Conversation
|
@pomadchin can i get a review from the maintainer? thanks. |
|
@ukby1234 ty for the PR! Also that's your first contribution! 🎉
What tests did fail? 👀 |
pomadchin
left a comment
There was a problem hiding this comment.
LGTM, could I ask to update REAMDE.md as well if possible?
Will merge once the question about the test is cleared.
You mean update the supported versions? |
yes! |
|
Ok the test failed because analyzer.checkAnalysis failed. The |
|
Will update the README.md to update the supported versions. @pomadchin |
|
ok updated README.md @pomadchin |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #966 +/- ##
==========================================
+ Coverage 96.21% 96.23% +0.01%
==========================================
Files 66 68 +2
Lines 1296 1328 +32
Branches 48 48
==========================================
+ Hits 1247 1278 +31
- Misses 49 50 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Created support for Spark 4.1 and Spark 4.2.
One unit tests failed because the generated analyzed plan fails the validation. This is the same plan generated for Spark 3.5 as well. Spark introduced a feature to reconcile schema for different datasets, and changed the unit to address the column-ordering issue.
Also tested with a locally published version against https://github.com/scalapb/sparksql-scalapb, and all tests there are passing as well.