Skip to content

Format TypeCompounds#7741

Merged
mernst merged 4 commits into
typetools:masterfrom
mernst:methodapplier-tostring
May 27, 2026
Merged

Format TypeCompounds#7741
mernst merged 4 commits into
typetools:masterfrom
mernst:methodapplier-tostring

Conversation

@mernst
Copy link
Copy Markdown
Member

@mernst mernst commented May 26, 2026

No description provided.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 26, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 74042d0a-17cc-4e7a-9dd0-dbe162743de8

📥 Commits

Reviewing files that changed from the base of the PR and between 4289a4f and da8345e.

📒 Files selected for processing (2)
  • framework/src/main/java/org/checkerframework/framework/util/element/ElementAnnotationUtil.java
  • framework/src/main/java/org/checkerframework/framework/util/element/MethodApplier.java

📝 Walkthrough

Walkthrough

Adds two public toString helpers in ElementAnnotationUtil: one formats a single TypeCompound as "typeCompound@position", and another formats an Iterable as a bracketed, comma-separated list using StringJoiner. Also updates two non-functional comments in MethodApplier.extractAndApply (removes a trailing word in one comment and adds terminal punctuation to a NOTE). No behavioral changes.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@framework/src/main/java/org/checkerframework/framework/util/element/MethodApplier.java`:
- Around line 167-170: Update the Javadoc for the method in class MethodApplier
that "Returns the formatted representation of a collection of TypeCompound{s}"
to use the correct parameter name: change the `@param` tag from "tc" to "targeted"
(the actual method parameter), so the Javadoc matches the method signature and
avoids doclint errors.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 4b31ea95-6028-434f-b2b2-18159243ee79

📥 Commits

Reviewing files that changed from the base of the PR and between 408c182 and 18242eb.

📒 Files selected for processing (1)
  • framework/src/main/java/org/checkerframework/framework/util/element/MethodApplier.java

smillst
smillst previously approved these changes May 26, 2026
@smillst smillst assigned mernst and unassigned smillst May 26, 2026
@mernst mernst merged commit 7298c1c into typetools:master May 27, 2026
35 checks passed
@mernst mernst deleted the methodapplier-tostring branch May 27, 2026 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants