Fixes regression where composition is not enabled by default.#122
Open
taylorhadden wants to merge 1 commit into
Open
Fixes regression where composition is not enabled by default.#122taylorhadden wants to merge 1 commit into
taylorhadden wants to merge 1 commit into
Conversation
Contributor
Author
|
I missed the message at the bottom of #119 talking about GBoard. That sounds like a massive pain. I'm curious: if GBoard primarily works with composition, how does not handling composition work at all? I unfortunately do not have an android device to test with. Is this a situation where we can detect GBoard and fall back to the less-than-ideal behavior? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure what happened here. What scenario/bug wants composition to be disabled?
Having composition disabled by default seems straight out incorrect; it causes terrible bugs with dictation, kanji composition, and the windows emoji picker.
The specific naming of
setCompositionEnabled/allowComposition/enableCompositionis whatever, but we should definitely have composition on by default.