fix(sensor): bound CodexParser to a recent-session window - #51
Closed
lghupan wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issue: N/A; follow-up to PR 34
What changed?
CodexParser now accepts max_age_days, defaults to a 14-day session window, and filters JSONL files by modification time before parsing them. AgentObserver forwards its configured age to Codex, matching the behavior of the other bounded parsers.
Tests cover the default window, old-file exclusion before parsing, recently modified resumed sessions, larger history windows, and observer forwarding.
Why?
Codex was the only JSONL-backed parser that ignored the observer age setting. Every scan reparsed the complete Codex history, causing processing cost to grow over time and making the configured collection window ineffective.
Modification time preserves sessions that were created earlier but resumed within the requested window.
How did you test it?
Potential risks
Low. Sessions with activity outside the configured window are intentionally excluded. Recently resumed sessions remain included because filtering uses file modification time, and the existing large history value continues to include older files.