test(discovery): add the adr-e2e command line - #72
Closed
pengyuzhang wants to merge 1 commit into
Closed
Conversation
Four subcommands over the pieces already here: check, run, score, report. score and report never touch a VM, which is the property that matters day to day. A scoring change is replayed over every recorded run in milliseconds, and somebody debugging a false positive needs nothing but the run directory. check delegates to the manifest_check module rather than repeating it. CI runs that module directly and does not need the rest of this file; two copies of the same rules would eventually disagree, and the copy CI runs is the one that matters. A guest that cannot scan is recorded as a failed run rather than as an empty inventory. A host that reported nothing and a host that never reported are different facts, and conflating them would score every entry a miss.
lghupan
approved these changes
Aug 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #71. Last of the series.
Four subcommands over the pieces already in place.
scoreandreportnever touch a VMThe property that matters day to day. A scoring change is replayed over every recorded run in milliseconds, and somebody debugging a false positive needs nothing but the run directory:
Exit code is 2 when the gate fails, so it can gate a release.
checkdelegates rather than duplicatesThe static checks are already a module because CI runs them directly (#59) and does not need the rest of this file. Two copies of the same rules would eventually disagree, and the copy CI runs is the one that matters.
A failed scan is a failed run
Not an empty inventory. A host that reported nothing and a host that never reported are different facts, and conflating them would score every entry a miss.
--driver dryRuns the installer against a guest that records commands instead of executing them. It exercises ordering, canary substitution and the recorded outcomes with no hypervisor — and it has no collector in it, so the score it produces is meaningless by construction and says so.
HARNESS.md
Also updated with what is actually validated:
Verification